Skip to content

HF Jet MC - fix weighting, adding new HF jet generator and its test - #1319

Merged
benedikt-voelkel merged 2 commits into
AliceO2Group:masterfrom
aimeric-landou:master
Nov 8, 2023
Merged

HF Jet MC - fix weighting, adding new HF jet generator and its test#1319
benedikt-voelkel merged 2 commits into
AliceO2Group:masterfrom
aimeric-landou:master

Conversation

@aimeric-landou

@aimeric-landou aimeric-landou commented Nov 7, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@aimeric-landou

aimeric-landou commented Nov 7, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

The build error is the following one:

################################
# Run O2DPG simulation testing #
################################

Following INI files will be tested:
  - MC/config/PWGGAJE/ini/GeneratorHFJETrigger_ccbar.ini
Test 1: /O2DPG/MC/config/PWGGAJE/ini/GeneratorHFJETrigger_ccbar.ini with generator External�[0;31m -> FAILED�[0m
�[0;31mError found in log /sw/BUILD/379c849e66b13f00e45dad483695d3696748a392/O2DPG-sim-tests/o2dpg-sim_tests/o2dpg_tests/generators/1_GeneratorHFJETrigger_ccbar.ini_External_dir/o2dpg-test-kine.log�[0m
1-### Testing /O2DPG/MC/config/PWGGAJE/ini/GeneratorHFJETrigger_ccbar.ini with generator External ###
2-
3-Processing External.C...
4---------------------------------
5-# Events: 100
6-# 4 (anti)quarks: 0
7-# signal hadrons: 254
8-# signal hadrons decaying in the correct channel: 254
9-Number of generated (anti)quarks 4 lower than expected
10:(int) 1

Having talked with @benedikt-voelkel about it, it is apparently due to a change to the test/run_generator_tests.sh script that was not propagated (the o2-sim command at line 88 is missing the option --configKeyValues "GeneratorPythia8.includePartonEvent=true). With the change, the test of GeneratorHFJETrigger_ccbar.ini is successful on my machine.

@benedikt-voelkel

benedikt-voelkel commented Nov 7, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

#1318 will solve the problem
Once merged, simply rebase your devs and push again

@benedikt-voelkel

benedikt-voelkel commented Nov 8, 2023

Copy link
Copy Markdown
Contributor

@aimeric-landou you can now rebase and push again

@benedikt-voelkel
benedikt-voelkel merged commit 5245357 into AliceO2Group:master Nov 8, 2023
benedikt-voelkel pushed a commit that referenced this pull request Nov 17, 2023
@aimeric-landou Benedikt Volkel
HF Jet MC - fix weighting, using new HF jet generator (#1319)
53a027e
benedikt-voelkel pushed a commit to benedikt-voelkel/O2DPG that referenced this pull request Nov 28, 2023
@aimeric-landou Benedikt Volkel
HF Jet MC - fix weighting, using new HF jet generator (AliceO2Group#1319
341bf9f 
)
benedikt-voelkel pushed a commit to benedikt-voelkel/O2DPG that referenced this pull request Dec 11, 2023
@aimeric-landou Benedikt Volkel
HF Jet MC - fix weighting, using new HF jet generator (AliceO2Group#1319
4a37a26 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gconesab gconesab gconesab approved these changes
@sawenzel sawenzel Awaiting requested review from sawenzel
@chiarazampolli chiarazampolli Awaiting requested review from chiarazampolli
@benedikt-voelkel benedikt-voelkel Awaiting requested review from benedikt-voelkel

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aimeric-landou @benedikt-voelkel @gconesab @isitaris